Commit 09e6d39c authored by Dan Carpenter's avatar Dan Carpenter Committed by Tomeu Vizoso
Browse files

accel/rocket: Fix some error checking in rocket_core_init() 



The problem is that pm_runtime_get_sync() can return 1 on success so
checking for zero doesn't work.  Use the pm_runtime_resume_and_get()
function instead.  The pm_runtime_resume_and_get() function does
additional cleanup as well so that's a bonus as well.

Fixes: 0810d5ad ("accel/rocket: Add job submission IOCTL")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarTomeu Vizoso <tomeu@tomeuvizoso.net>
Link: https://lore.kernel.org/r/aKcRW6fsRP_o5C_y@stanley.mountain
parent 78e39995

drivers/accel/rocket/rocket_core.c

+1 −1
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ int rocket_core_init(struct rocket_core *core) 


	pm_runtime_enable(dev);



	err = pm_runtime_get_sync(dev);

	err = pm_runtime_resume_and_get(dev);

	if (err) {

		rocket_job_fini(core);

		return err;