Commit 0c4a13ba authored by Junrui Luo's avatar Junrui Luo Committed by Takashi Iwai
Browse files

ALSA: wavefront: Fix integer overflow in sample size validation 



The wavefront_send_sample() function has an integer overflow issue
when validating sample size. The header->size field is u32 but gets
cast to int for comparison with dev->freemem

Fix by using unsigned comparison to avoid integer overflow.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJunrui Luo <moonafterrain@outlook.com>
Link: https://patch.msgid.link/SYBPR01MB7881B47789D1B060CE8BF4C3AFC2A@SYBPR01MB7881.ausprd01.prod.outlook.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e11c5c13

sound/isa/wavefront/wavefront_synth.c

+2 −2
Original line number Diff line number Diff line
@@ -950,9 +950,9 @@ wavefront_send_sample (snd_wavefront_t *dev, 
	if (header->size) {

		dev->freemem = wavefront_freemem (dev);



		if (dev->freemem < (int)header->size) {

		if (dev->freemem < 0 || dev->freemem < header->size) {

			dev_err(dev->card->dev,

				"insufficient memory to load %d byte sample.\n",

				"insufficient memory to load %u byte sample.\n",

				header->size);

			return -ENOMEM;

		}