Unverified Commit 0d435a7e authored by Alexander A. Klimov's avatar Alexander A. Klimov Committed by Mark Brown
Browse files

ASoC: codecs: fs210x: fix possible buffer overflow 



In fs210x_effect_scene_info(), a string was copied like this:

    strscpy(DST, SRC, strlen(SRC) + 1);

A buffer overflow would happen if strlen(SRC) >= sizeof(DST).
Actually, strscpy() must be used this way:

    strscpy(DST, SRC, sizeof(DST));
    strscpy(DST, SRC); // defaults to sizeof(DST)

Fixes: 75611770 ("ASoC: codecs: Add FourSemi FS2104/5S audio amplifier driver")
Signed-off-by: default avatarAlexander A. Klimov <grandmaster@al2klimov.de>
Link: https://patch.msgid.link/20260513190852.196723-2-grandmaster@al2klimov.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9c0f5bbf

sound/soc/codecs/fs210x.c

+1 −1
Original line number Diff line number Diff line
@@ -968,7 +968,7 @@ static int fs210x_effect_scene_info(struct snd_kcontrol *kcontrol, 
	if (scene->name)

		name = scene->name;



	strscpy(uinfo->value.enumerated.name, name, strlen(name) + 1);

	strscpy(uinfo->value.enumerated.name, name);



	return 0;

}