Commit 0d510778 authored by Jon Hunter's avatar Jon Hunter Committed by Alexandre Belloni
Browse files

Revert "rtc: cpcap: Fix initial enable_irq/disable_irq balance" 



Commit e0762fd2 ("rtc: cpcap: Fix initial enable_irq/disable_irq
balance") set 'alarm_enabled' prior to calling the function
devm_request_threaded_irq() because this enables the IRQ. However, right
after calling devm_request_threaded_irq(), the driver calls
disable_irq() to disable the IRQ and so now 'alarm_enabled' will be true
but the IRQ is actually disabled. Revert this commit to fix the
'alarm_enabled' state.

Fixes: e0762fd2 ("rtc: cpcap: Fix initial enable_irq/disable_irq balance")
Signed-off-by: default avatarJon Hunter <jonathanh@nvidia.com>
Link: https://patch.msgid.link/20251031103741.945460-2-jonathanh@nvidia.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent b1c9390f

drivers/rtc/rtc-cpcap.c

+0 −1
Original line number Diff line number Diff line
@@ -268,7 +268,6 @@ static int cpcap_rtc_probe(struct platform_device *pdev) 
		return err;



	rtc->alarm_irq = platform_get_irq(pdev, 0);

	rtc->alarm_enabled = true;

	err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,

					cpcap_rtc_alarm_irq,

					IRQF_TRIGGER_NONE | IRQF_ONESHOT,