Commit 14645864 authored by Karthik Poosa's avatar Karthik Poosa Committed by Matt Roper
Browse files

drm/xe/hwmon: Fix PL1 disable flow in xe_hwmon_power_max_write 



In xe_hwmon_power_max_write, for PL1 disable supported case, instead of
returning after PL1 disable, PL1 enable path was also being run.
Fixed it by returning after disable.

v2: Correct typo and grammar in commit message. (Jonathan)

Signed-off-by: default avatarKarthik Poosa <karthik.poosa@intel.com>
Fixes: fef6dd12 ("drm/xe/hwmon: Protect hwmon rw attributes with hwmon_lock")
Reviewed-by: default avatarJonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240801112424.1841766-1-karthik.poosa@intel.com
parent f1e6f895

drivers/gpu/drm/xe/xe_hwmon.c

+2 −1
Original line number Diff line number Diff line
@@ -203,9 +203,10 @@ static int xe_hwmon_power_max_write(struct xe_hwmon *hwmon, int channel, long va 
		reg_val = xe_mmio_rmw32(hwmon->gt, rapl_limit, PKG_PWR_LIM_1_EN, 0);

		reg_val = xe_mmio_read32(hwmon->gt, rapl_limit);

		if (reg_val & PKG_PWR_LIM_1_EN) {

			drm_warn(&gt_to_xe(hwmon->gt)->drm, "PL1 disable is not supported!\n");

			ret = -EOPNOTSUPP;

			goto unlock;

		}

		goto unlock;

	}



	/* Computation in 64-bits to avoid overflow. Round to nearest. */