Commit 1558b1a8 authored by Hao Ge's avatar Hao Ge Committed by Shawn Guo
Browse files

firmware/imx-dsp: Fix use_after_free in imx_dsp_setup_channels() 



dsp_chan->name and chan_name points to same block of memory,
because dev_err still needs to be used it,so we need free
it's memory after use to avoid use_after_free.

Fixes: e527adfb ("firmware: imx-dsp: Fix an error handling path in imx_dsp_setup_channels()")
Signed-off-by: default avatarHao Ge <gehao@kylinos.cn>
Reviewed-by: default avatarDaniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent f09752ea

drivers/firmware/imx/imx-dsp.c

+1 −1
Original line number Diff line number Diff line
@@ -114,11 +114,11 @@ static int imx_dsp_setup_channels(struct imx_dsp_ipc *dsp_ipc) 
		dsp_chan->idx = i % 2;

		dsp_chan->ch = mbox_request_channel_byname(cl, chan_name);

		if (IS_ERR(dsp_chan->ch)) {

			kfree(dsp_chan->name);

			ret = PTR_ERR(dsp_chan->ch);

			if (ret != -EPROBE_DEFER)

				dev_err(dev, "Failed to request mbox chan %s ret %d\n",

					chan_name, ret);

			kfree(dsp_chan->name);

			goto out;

		}