Commit 17b0dfa1 authored by Pavan Chebbi's avatar Pavan Chebbi Committed by Jakub Kicinski
Browse files

bnxt_en: Skip ethtool RSS context configuration in ifdown state 



The current implementation requires the ifstate to be up when
configuring the RSS contexts.  It will try to fetch the RX ring
IDs and will crash if it is in ifdown state.  Return error if
!netif_running() to prevent the crash.

An improved implementation is in the works to allow RSS contexts
to be changed while in ifdown state.

Fixes: b3d0083c ("bnxt_en: Support RSS contexts in ethtool .{get|set}_rxfh()")
Reviewed-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: default avatarSomnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20240409215431.41424-2-michael.chan@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 930fd7fe

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+5 −0
Original line number Diff line number Diff line
@@ -1876,6 +1876,11 @@ static int bnxt_set_rxfh_context(struct bnxt *bp, 
		return -EOPNOTSUPP;

	}



	if (!netif_running(bp->dev)) {

		NL_SET_ERR_MSG_MOD(extack, "Unable to set RSS contexts when interface is down");

		return -EAGAIN;

	}



	if (*rss_context != ETH_RXFH_CONTEXT_ALLOC) {

		rss_ctx = bnxt_get_rss_ctx_from_index(bp, *rss_context);

		if (!rss_ctx) {