Commit 1a0e57eb authored by Lijo Lazar's avatar Lijo Lazar Committed by Alex Deucher
Browse files

drm/amdgpu/vcn: Fix double-free of vcn dump buffer 



The buffer is already freed as part of amdgpu_vcn_reg_dump_fini(). The
issue is introduced by below patch series.

Fixes: de55cbff ("drm/amdgpu/vcn: Add regdump helper functions")
Signed-off-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Reviewed-by: default avatarSathishkumar S <sathishkumar.sundararaju@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c5c62160

drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c

+1 −0
Original line number Diff line number Diff line
@@ -1549,6 +1549,7 @@ int amdgpu_vcn_reg_dump_init(struct amdgpu_device *adev, 
static void amdgpu_vcn_reg_dump_fini(struct amdgpu_device *adev)

{

	kfree(adev->vcn.ip_dump);

	adev->vcn.ip_dump = NULL;

	adev->vcn.reg_list = NULL;

	adev->vcn.reg_count = 0;

}

drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c

+0 −1
Original line number Diff line number Diff line
@@ -354,7 +354,6 @@ static int vcn_v3_0_sw_fini(struct amdgpu_ip_block *ip_block) 
			return r;

	}



	kfree(adev->vcn.ip_dump);

	return 0;

}

drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c

+0 −2
Original line number Diff line number Diff line
@@ -280,8 +280,6 @@ static int vcn_v4_0_3_sw_fini(struct amdgpu_ip_block *ip_block) 
			return r;

	}



	kfree(adev->vcn.ip_dump);



	return 0;

}

drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c

+0 −2
Original line number Diff line number Diff line
@@ -275,8 +275,6 @@ static int vcn_v4_0_5_sw_fini(struct amdgpu_ip_block *ip_block) 
			return r;

	}



	kfree(adev->vcn.ip_dump);



	return 0;

}