Commit 1d232f79 authored by Brian Masney's avatar Brian Masney Committed by Dmitry Baryshkov
Browse files

drm/msm/dsi_phy_14nm: convert from divider_round_rate() to divider_determine_rate()



The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed.

Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:

    req->rate = divider_round_rate(...)

This is invalid in the case when an error occurs since it can set the
rate to a negative value.

Fixes: cc41f29a ("drm/msm/dsi_phy_14nm: convert from round_rate() to determine_rate()")
Signed-off-by: default avatarBrian Masney <bmasney@redhat.com>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: default avatarAbel Vesa <abel.vesa@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/697613/
Link: https://lore.kernel.org/r/20260108-clk-divider-round-rate-v1-24-535a3ed73bf3@redhat.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
parent 23c39217
Loading
Loading
Loading
Loading
+1 −6
Original line number Diff line number Diff line
@@ -628,12 +628,7 @@ static int dsi_pll_14nm_postdiv_determine_rate(struct clk_hw *hw,

	DBG("DSI%d PLL parent rate=%lu", pll_14nm->phy->id, req->rate);

	req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
				       NULL,
				       postdiv->width,
				       postdiv->flags);

	return 0;
	return divider_determine_rate(hw, req, NULL, postdiv->width, postdiv->flags);
}

static int dsi_pll_14nm_postdiv_set_rate(struct clk_hw *hw, unsigned long rate,