Commit 1d50071b authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: gadget: pxa25x_udc: remove dentry storage for debugfs file 



There is no need to store the dentry pointer for a debugfs file that we
only use to remove it when the device goes away.  debugfs can do the
lookup for us instead, saving us some trouble, and making things smaller
overall.

Cc: Daniel Mack <daniel@zonque.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: linux-usb@vger.kernel.org
Acked-by: default avatarDaniel Mack <daniel@zonque.org>
Link: https://lore.kernel.org/r/20210518162054.3697992-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1531a2bb

drivers/usb/gadget/udc/pxa25x_udc.c

+2 −2
Original line number Diff line number Diff line
@@ -1338,10 +1338,10 @@ DEFINE_SHOW_ATTRIBUTE(udc_debug); 


#define create_debug_files(dev) \

	do { \

		dev->debugfs_udc = debugfs_create_file(dev->gadget.name, \

		debugfs_create_file(dev->gadget.name, \

			S_IRUGO, NULL, dev, &udc_debug_fops); \

	} while (0)

#define remove_debug_files(dev) debugfs_remove(dev->debugfs_udc)

#define remove_debug_files(dev) debugfs_remove(debugfs_lookup(dev->gadget.name, NULL))



#else	/* !CONFIG_USB_GADGET_DEBUG_FILES */

drivers/usb/gadget/udc/pxa25x_udc.h

+0 −4
Original line number Diff line number Diff line
@@ -116,10 +116,6 @@ struct pxa25x_udc { 
	struct usb_phy				*transceiver;

	u64					dma_mask;

	struct pxa25x_ep			ep [PXA_UDC_NUM_ENDPOINTS];



#ifdef CONFIG_USB_GADGET_DEBUG_FS

	struct dentry				*debugfs_udc;

#endif

	void __iomem				*regs;

};

#define to_pxa25x(g)	(container_of((g), struct pxa25x_udc, gadget))