Commit 1d512b1a authored by Qiuxu Zhuo's avatar Qiuxu Zhuo Committed by Tony Luck
Browse files

EDAC/igen6: Initialize edac_op_state according to the configuration data 



Currently, igen6_edac sets edac_op_state to EDAC_OPSTATE_NMI, while the
driver also supports memory errors reported from Machine Check. Initialize
edac_op_state to the correct value according to the configuration data
that the driver probed.

Signed-off-by: default avatarQiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/all/20241106114024.941659-2-orange@aiven.io
parent fefaae90

drivers/edac/igen6_edac.c

+11 −2
Original line number Diff line number Diff line
@@ -1350,6 +1350,15 @@ static void unregister_err_handler(void) 
	unregister_nmi_handler(NMI_SERR, IGEN6_NMI_NAME);

}



static void opstate_set(struct res_config *cfg)

{

	/* Set the mode according to the configuration data. */

	if (cfg->machine_check)

		edac_op_state = EDAC_OPSTATE_INT;

	else

		edac_op_state = EDAC_OPSTATE_NMI;

}



static int igen6_probe(struct pci_dev *pdev, const struct pci_device_id *ent)

{

	u64 mchbar;
@@ -1367,6 +1376,8 @@ static int igen6_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	if (rc)

		goto fail;



	opstate_set(res_cfg);



	for (i = 0; i < res_cfg->num_imc; i++) {

		rc = igen6_register_mci(i, mchbar, pdev);

		if (rc)
@@ -1450,8 +1461,6 @@ static int __init igen6_init(void) 
	if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR)))

		return -EBUSY;



	edac_op_state = EDAC_OPSTATE_NMI;



	rc = pci_register_driver(&igen6_driver);

	if (rc)

		return rc;