Commit 1d5f40e0 authored by Kishon Vijay Abraham I's avatar Kishon Vijay Abraham I Committed by Vinod Koul
Browse files

phy: cadence: Sierra: Move all reset_control_get*() to a separate function 



No functional change. Group devm_reset_control_get() and
devm_reset_control_get_optional() to a separate function.

Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Reviewed-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20210319124128.13308-7-kishon@ti.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 7e016cbc

drivers/phy/cadence/phy-cadence-sierra.c

+25 −11
Original line number Diff line number Diff line
@@ -509,6 +509,28 @@ static int cdns_sierra_phy_get_clocks(struct cdns_sierra_phy *sp, 
	return 0;

}



static int cdns_sierra_phy_get_resets(struct cdns_sierra_phy *sp,

				      struct device *dev)

{

	struct reset_control *rst;



	rst = devm_reset_control_get(dev, "sierra_reset");

	if (IS_ERR(rst)) {

		dev_err(dev, "failed to get reset\n");

		return PTR_ERR(rst);

	}

	sp->phy_rst = rst;



	rst = devm_reset_control_get_optional(dev, "sierra_apb");

	if (IS_ERR(rst)) {

		dev_err(dev, "failed to get apb reset\n");

		return PTR_ERR(rst);

	}

	sp->apb_rst = rst;



	return 0;

}



static int cdns_sierra_phy_probe(struct platform_device *pdev)

{

	struct cdns_sierra_phy *sp;
@@ -559,17 +581,9 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev) 
	if (ret)

		return ret;



	sp->phy_rst = devm_reset_control_get(dev, "sierra_reset");

	if (IS_ERR(sp->phy_rst)) {

		dev_err(dev, "failed to get reset\n");

		return PTR_ERR(sp->phy_rst);

	}



	sp->apb_rst = devm_reset_control_get_optional(dev, "sierra_apb");

	if (IS_ERR(sp->apb_rst)) {

		dev_err(dev, "failed to get apb reset\n");

		return PTR_ERR(sp->apb_rst);

	}

	ret = cdns_sierra_phy_get_resets(sp, dev);

	if (ret)

		return ret;



	ret = clk_prepare_enable(sp->clk);

	if (ret)