Commit 1dabf00e authored by Dikshita Agarwal's avatar Dikshita Agarwal Committed by Hans Verkuil
Browse files

media: iris: gen1: Destroy internal buffers after FW releases 



After the firmware releases internal buffers, the driver was not
destroying them. This left stale allocations that were no longer used,
especially across resolution changes where new buffers are allocated per
the updated requirements. As a result, memory was wasted until session
close.

Destroy internal buffers once the release response is received from the
firmware.

Fixes: 73702f45 ("media: iris: allocate, initialize and queue internal buffers")
Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: default avatarDikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Reviewed-by: default avatarVikash Garodia <vikash.garodia@oss.qualcomm.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarBryan O'Donoghue <bod@kernel.org>
Signed-off-by: default avatarHans Verkuil <hverkuil+cisco@kernel.org>
parent 811dbc54

drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c

+2 −0
Original line number Diff line number Diff line
@@ -441,6 +441,8 @@ static int iris_hfi_gen1_session_unset_buffers(struct iris_inst *inst, struct ir 
		goto exit;



	ret = iris_wait_for_session_response(inst, false);

	if (!ret)

		ret = iris_destroy_internal_buffer(inst, buf);



exit:

	kfree(pkt);