Commit 1edf4899 authored by Pawel Laszczak's avatar Pawel Laszczak Committed by Greg Kroah-Hartman
Browse files

usb: cdnsp: Fixes error: uninitialized symbol 'len' 



The patch 5bc38d33: "usb: cdnsp: Fixes issue with redundant
Status Stage" leads to the following Smatch static checker warning:

  drivers/usb/cdns3/cdnsp-ep0.c:470 cdnsp_setup_analyze()
  error: uninitialized symbol 'len'.

cc: <stable@vger.kernel.org>
Fixes: 5bc38d33 ("usb: cdnsp: Fixes issue with redundant Status Stage")
Signed-off-by: default avatarPawel Laszczak <pawell@cadence.com>
Link: https://lore.kernel.org/r/20230331090600.454674-1-pawell@cadence.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e07fec47

drivers/usb/cdns3/cdnsp-ep0.c

+1 −2
Original line number Diff line number Diff line
@@ -414,7 +414,7 @@ static int cdnsp_ep0_std_request(struct cdnsp_device *pdev, 
void cdnsp_setup_analyze(struct cdnsp_device *pdev)

{

	struct usb_ctrlrequest *ctrl = &pdev->setup;

	int ret = 0;

	int ret = -EINVAL;

	u16 len;



	trace_cdnsp_ctrl_req(ctrl);
@@ -424,7 +424,6 @@ void cdnsp_setup_analyze(struct cdnsp_device *pdev) 


	if (pdev->gadget.state == USB_STATE_NOTATTACHED) {

		dev_err(pdev->dev, "ERR: Setup detected in unattached state\n");

		ret = -EINVAL;

		goto out;

	}