Commit 1f037e3a authored by Qianfeng Rong's avatar Qianfeng Rong Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix incorrect sign of error code in START_SP_W_RETRIES() 



Change the error code EAGAIN to -EAGAIN in START_SP_W_RETRIES() to align
with qla2x00_start_sp() returning negative error codes or QLA_SUCCESS,
preventing logical errors.  Additionally, the '_rval' variable should
store negative error codes to conform to Linux kernel error code
conventions.

Fixes: 9803fb5d ("scsi: qla2xxx: Fix task management cmd failure")
Signed-off-by: default avatarQianfeng Rong <rongqianfeng@vivo.com>
Message-ID: <20250905075446.381139-3-rongqianfeng@vivo.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 066b8f3f

drivers/scsi/qla2xxx/qla_init.c

+2 −2
Original line number Diff line number Diff line
@@ -2059,11 +2059,11 @@ static void qla_marker_sp_done(srb_t *sp, int res) 
	int cnt = 5; \

	do { \

		if (_chip_gen != sp->vha->hw->chip_reset || _login_gen != sp->fcport->login_gen) {\

			_rval = EINVAL; \

			_rval = -EINVAL; \

			break; \

		} \

		_rval = qla2x00_start_sp(_sp); \

		if (_rval == EAGAIN) \

		if (_rval == -EAGAIN) \

			msleep(1); \

		else \

			break; \