Unverified Commit 1fe9596a authored by Kurt Borja's avatar Kurt Borja Committed by Ilpo Järvinen
Browse files

platform/x86: alienware-wmi-wmax: Fix uninitialized bitmap in awcc_hwmon_fans_init() 



Initialize fan_temps bitmap to zero before using it for the first time
in each iteration.

Fixes: d6999078 ("platform/x86: alienware-wmi-wmax: Add HWMON support")
Signed-off-by: default avatarKurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250425-temp-id-fix-v1-1-372d71f732bf@gmail.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 317bbe16

drivers/platform/x86/dell/alienware-wmi-wmax.c

+2 −2
Original line number Diff line number Diff line
@@ -1027,6 +1027,8 @@ static int awcc_hwmon_fans_init(struct wmi_device *wdev) 
		if (ret)

			return ret;



		bitmap_zero(fan_temps, AWCC_ID_BITMAP_SIZE);



		for (j = 0; j < temp_count; j++) {

			ret = awcc_get_fan_sensors(wdev, AWCC_OP_GET_FAN_TEMP_ID,

						   id, j, &temp_id);
@@ -1048,8 +1050,6 @@ static int awcc_hwmon_fans_init(struct wmi_device *wdev) 
		bitmap_gather(gather, fan_temps, priv->temp_sensors, AWCC_ID_BITMAP_SIZE);

		bitmap_copy(&fan_data->auto_channels_temp, gather, BITS_PER_LONG);

		priv->fan_data[i] = fan_data;



		bitmap_zero(fan_temps, AWCC_ID_BITMAP_SIZE);

	}



	return 0;