Commit 20a0c20f authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

octeontx2-af: Fix error code in rvu_mbox_init() 



The error code was intended to be -EINVAL here, but it was accidentally
changed to returning success.  Set the error code.

Fixes: e53ee4ac ("octeontx2-af: CN20k basic mbox operations and structures")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent beead7ee

drivers/net/ethernet/marvell/octeontx2/af/rvu.c

+2 −1
Original line number Diff line number Diff line
@@ -2458,9 +2458,9 @@ static int rvu_mbox_init(struct rvu *rvu, struct mbox_wq_info *mw, 
			 void (mbox_handler)(struct work_struct *),

			 void (mbox_up_handler)(struct work_struct *))

{

	int err = -EINVAL, i, dir, dir_up;

	void __iomem **mbox_regions;

	struct ng_rvu *ng_rvu_mbox;

	int err, i, dir, dir_up;

	void __iomem *reg_base;

	struct rvu_work *mwork;

	unsigned long *pf_bmap;
@@ -2526,6 +2526,7 @@ static int rvu_mbox_init(struct rvu *rvu, struct mbox_wq_info *mw, 
			goto free_regions;

		break;

	default:

		err = -EINVAL;

		goto free_regions;

	}