Commit 2317dc2c authored by Thorsten Blum's avatar Thorsten Blum Committed by Daniel Borkmann
Browse files

bpf, devmap: Remove unnecessary if check in for loop 



The iterator variable dst cannot be NULL and the if check can be removed.
Remove it and fix the following Coccinelle/coccicheck warning reported
by itnull.cocci:

	ERROR: iterator variable bound on line 762 cannot be NULL

Signed-off-by: default avatarThorsten Blum <thorsten.blum@toblux.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Reviewed-by: default avatarToke Høiland-Jørgensen <toke@redhat.com>
Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
Link: https://lore.kernel.org/bpf/20240529101900.103913-2-thorsten.blum@toblux.com
parent 7d0b3953

kernel/bpf/devmap.c

+0 −3
Original line number Diff line number Diff line
@@ -760,9 +760,6 @@ int dev_map_redirect_multi(struct net_device *dev, struct sk_buff *skb, 
		for (i = 0; i < dtab->n_buckets; i++) {

			head = dev_map_index_hash(dtab, i);

			hlist_for_each_entry_safe(dst, next, head, index_hlist) {

				if (!dst)

					continue;



				if (is_ifindex_excluded(excluded_devices, num_excluded,

							dst->dev->ifindex))

					continue;