Unverified Commit 2324be17 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Krzysztof Wilczyński
Browse files

PCI: xilinx-xdma: Fix error code in xilinx_pl_dma_pcie_init_irq_domain() 

Currently, if the function irq_domain_add_linear() fails to allocate
a new IRQ domain and returns NULL, we would then still return a success
from the xilinx_pl_dma_pcie_init_irq_domain() function regardless, as
the PTR_ERR(NULL) would return a value of zero.  This is not a desirable
outcome.

Thus, fix the incorrect error code and return the -ENOMEM error code if
the irq_domain_add_linear() fails to allocate a new IRQ domain.

[kwilczynski: commit log]
Link: https://lore.kernel.org/linux-pci/20231030072757.3236546-1-harshit.m.mogalapalli@oracle.com


Fixes: 8d786149 ("PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver")
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
parent 7aa5f8fc

drivers/pci/controller/pcie-xilinx-dma-pl.c

+1 −1
Original line number Diff line number Diff line
@@ -576,7 +576,7 @@ static int xilinx_pl_dma_pcie_init_irq_domain(struct pl_dma_pcie *port) 
						  &intx_domain_ops, port);

	if (!port->intx_domain) {

		dev_err(dev, "Failed to get a INTx IRQ domain\n");

		return PTR_ERR(port->intx_domain);

		return -ENOMEM;

	}



	irq_domain_update_bus_token(port->intx_domain, DOMAIN_BUS_WIRED);