Unverified Commit 7aa5f8fc authored by Krzysztof Wilczyński's avatar Krzysztof Wilczyński
Browse files

PCI: xilinx-xdma: Fix uninitialized symbols in xilinx_pl_dma_pcie_setup_irq() 

The error paths that follow calls to the devm_request_irq() functions
within the xilinx_pl_dma_pcie_setup_irq() reference an uninitialized
symbol each that also so happens to be incorrect.

Thus, fix this omission and reference the correct variable when invoking
a given dev_err() function following an error.

This problem was found using smatch via the 0-DAY CI Kernel Test service:

  drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
  drivers/pci/controller/pcie-xilinx-dma-pl.c:645 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.

Fixes: 8d786149 ("PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver")
Link: https://lore.kernel.org/oe-kbuild/202312120248.5DblxkBp-lkp@intel.com/


Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202312120248.5DblxkBp-lkp@intel.com/


Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
parent b642e081

drivers/pci/controller/pcie-xilinx-dma-pl.c

+2 −2
Original line number Diff line number Diff line
@@ -635,14 +635,14 @@ static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port) 
	err = devm_request_irq(dev, port->intx_irq, xilinx_pl_dma_pcie_intx_flow,

			       IRQF_SHARED | IRQF_NO_THREAD, NULL, port);

	if (err) {

		dev_err(dev, "Failed to request INTx IRQ %d\n", irq);

		dev_err(dev, "Failed to request INTx IRQ %d\n", port->intx_irq);

		return err;

	}



	err = devm_request_irq(dev, port->irq, xilinx_pl_dma_pcie_event_flow,

			       IRQF_SHARED | IRQF_NO_THREAD, NULL, port);

	if (err) {

		dev_err(dev, "Failed to request event IRQ %d\n", irq);

		dev_err(dev, "Failed to request event IRQ %d\n", port->irq);

		return err;

	}