Commit 2396eefa authored by Zijun Hu's avatar Zijun Hu Committed by Thomas Gleixner
Browse files

genirq/devres: Don't free interrupt which is not managed by devres 



If devres_destroy() does not find a matching devres entry, then
devm_free_irq() emits a warning and tries to free the interrupt.

That's wrong as devm_free_irq() should only undo what devm_request_irq()
set up.

Replace devres_destroy() with a call to devres_release() which only invokes
the release function (free_irq()) in case that a matching devres entry was
found.

[ tglx: Massaged change log ]

Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241018-devres_kernel_fix-v2-1-08918ae84982@quicinc.com
parent bc88d44b

kernel/irq/devres.c

+1 −2
Original line number Diff line number Diff line
@@ -141,9 +141,8 @@ void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id) 
{

	struct irq_devres match_data = { irq, dev_id };



	WARN_ON(devres_destroy(dev, devm_irq_release, devm_irq_match,

	WARN_ON(devres_release(dev, devm_irq_release, devm_irq_match,

			       &match_data));

	free_irq(irq, dev_id);

}

EXPORT_SYMBOL(devm_free_irq);