Commit 23ea3c70 authored by Daisuke Matsuda's avatar Daisuke Matsuda Committed by Leon Romanovsky
Browse files

RDMA/rxe: Remove 32-bit architecture support 



Major linux distibutions have phased out support for 32-bit machines. Since
rxe is primarily used for development and testing, the benefit of
maintaining 32-bit support is minimal. This change simplifies ATOMIC WRITE
implementations and improves maintainability of the driver.

Signed-off-by: default avatarDaisuke Matsuda <matsuda-daisuke@fujitsu.com>
Link: https://patch.msgid.link/20250421025101.3588139-1-matsuda-daisuke@fujitsu.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent d85080df

drivers/infiniband/sw/rxe/Kconfig

+1 −1
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only

config RDMA_RXE

	tristate "Software RDMA over Ethernet (RoCE) driver"

	depends on INET && PCI && INFINIBAND

	depends on INET && PCI && INFINIBAND && 64BIT

	depends on INFINIBAND_VIRT_DMA

	select NET_UDP_TUNNEL

	select CRC32

drivers/infiniband/sw/rxe/rxe_loc.h

+1 −5
Original line number Diff line number Diff line
@@ -196,6 +196,7 @@ enum resp_states rxe_odp_atomic_op(struct rxe_mr *mr, u64 iova, int opcode, 
				   u64 compare, u64 swap_add, u64 *orig_val);

int rxe_odp_flush_pmem_iova(struct rxe_mr *mr, u64 iova,

			    unsigned int length);

enum resp_states rxe_odp_do_atomic_write(struct rxe_mr *mr, u64 iova, u64 value);

#else /* CONFIG_INFINIBAND_ON_DEMAND_PAGING */

static inline int

rxe_odp_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length, u64 iova,
@@ -219,11 +220,6 @@ static inline int rxe_odp_flush_pmem_iova(struct rxe_mr *mr, u64 iova, 
{

	return -EOPNOTSUPP;

}

#endif /* CONFIG_INFINIBAND_ON_DEMAND_PAGING */



#ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING

enum resp_states rxe_odp_do_atomic_write(struct rxe_mr *mr, u64 iova, u64 value);

#else

static inline enum resp_states rxe_odp_do_atomic_write(struct rxe_mr *mr,

						       u64 iova, u64 value)

{

drivers/infiniband/sw/rxe/rxe_mr.c

+0 −8
Original line number Diff line number Diff line
@@ -539,8 +539,6 @@ enum resp_states rxe_mr_do_atomic_op(struct rxe_mr *mr, u64 iova, int opcode, 
	return RESPST_NONE;

}



#if defined CONFIG_64BIT

/* only implemented or called for 64 bit architectures */

enum resp_states rxe_mr_do_atomic_write(struct rxe_mr *mr, u64 iova, u64 value)

{

	unsigned int page_offset;
@@ -580,12 +578,6 @@ enum resp_states rxe_mr_do_atomic_write(struct rxe_mr *mr, u64 iova, u64 value) 


	return RESPST_NONE;

}

#else

enum resp_states rxe_mr_do_atomic_write(struct rxe_mr *mr, u64 iova, u64 value)

{

	return RESPST_ERR_UNSUPPORTED_OPCODE;

}

#endif



int advance_dma_data(struct rxe_dma_info *dma, unsigned int length)

{

drivers/infiniband/sw/rxe/rxe_odp.c

+0 −1
Original line number Diff line number Diff line
@@ -380,7 +380,6 @@ int rxe_odp_flush_pmem_iova(struct rxe_mr *mr, u64 iova, 
	return 0;

}



/* CONFIG_64BIT=y */

enum resp_states rxe_odp_do_atomic_write(struct rxe_mr *mr, u64 iova, u64 value)

{

	struct ib_umem_odp *umem_odp = to_ib_umem_odp(mr->umem);

drivers/infiniband/sw/rxe/rxe_param.h

+1 −4
Original line number Diff line number Diff line
@@ -53,12 +53,9 @@ enum rxe_device_param { 
					| IB_DEVICE_MEM_WINDOW

					| IB_DEVICE_FLUSH_GLOBAL

					| IB_DEVICE_FLUSH_PERSISTENT

#ifdef CONFIG_64BIT

					| IB_DEVICE_MEM_WINDOW_TYPE_2B

					| IB_DEVICE_ATOMIC_WRITE,

#else

					| IB_DEVICE_MEM_WINDOW_TYPE_2B,

#endif /* CONFIG_64BIT */



	RXE_MAX_SGE			= 32,

	RXE_MAX_WQE_SIZE		= sizeof(struct rxe_send_wqe) +

					  sizeof(struct ib_sge) * RXE_MAX_SGE,