Commit 27238548 authored by Mario Limonciello's avatar Mario Limonciello Committed by Alex Deucher
Browse files

drm/amd/display: Drop unnecessary ret variable for enable_assr() 



[Why]
enable_assr() has a res variable that only is changed in one block with
no cleanup necessary.

[How]
Remove variable and return early from failure cases.

Reviewed-by: default avatarAlex Hung <alex.hung@amd.com>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarTom Chung <chiahsuan.chung@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 6b675ab8

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c

+2 −3
Original line number Diff line number Diff line
@@ -457,7 +457,6 @@ static bool enable_assr(void *handle, struct dc_link *link) 
	struct mod_hdcp hdcp = hdcp_work->hdcp;

	struct psp_context *psp = hdcp.config.psp.handle;

	struct ta_dtm_shared_memory *dtm_cmd;

	bool res = true;



	if (!psp->dtm_context.context.initialized) {

		DRM_INFO("Failed to enable ASSR, DTM TA is not initialized.");
@@ -478,10 +477,10 @@ static bool enable_assr(void *handle, struct dc_link *link) 


	if (dtm_cmd->dtm_status != TA_DTM_STATUS__SUCCESS) {

		DRM_INFO("Failed to enable ASSR");

		res = false;

		return false;

	}



	return res;

	return true;

}



static void update_config(void *handle, struct cp_psp_stream_config *config)