Commit 28330ceb authored by Viresh Kumar's avatar Viresh Kumar
Browse files

OPP: debugfs: Fix warning around icc_get_name() 



If the kernel isn't built with interconnect support, icc_get_name()
returns NULL and we get following warning:

drivers/opp/debugfs.c: In function 'bw_name_read':
drivers/opp/debugfs.c:43:42: error: '%.62s' directive argument is null [-Werror=format-overflow=]
         i = scnprintf(buf, sizeof(buf), "%.62s\n", icc_get_name(path));

Fix it.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402141313.81ltVF5g-lkp@intel.com/


Fixes: 0430b1d5 ("opp: Expose bandwidth information via debugfs")
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarDhruva Gole <d-gole@ti.com>
parent 992e8833

drivers/opp/debugfs.c

+4 −2
Original line number Diff line number Diff line
@@ -37,10 +37,12 @@ static ssize_t bw_name_read(struct file *fp, char __user *userbuf, 
			    size_t count, loff_t *ppos)

{

	struct icc_path *path = fp->private_data;

	const char *name = icc_get_name(path);

	char buf[64];

	int i;

	int i = 0;



	i = scnprintf(buf, sizeof(buf), "%.62s\n", icc_get_name(path));

	if (name)

		i = scnprintf(buf, sizeof(buf), "%.62s\n", name);



	return simple_read_from_buffer(userbuf, count, ppos, buf, i);

}