Unverified Commit 28d21dfc authored by Akif Ejaz's avatar Akif Ejaz Committed by Mark Brown
Browse files

spi: cadence-qspi: Remove redundant pm_runtime_mark_last_busy call 



The pm_runtime_mark_last_busy() call is redundant in probe function
as pm_runtime_put_autosuspend() already calls pm_runtime_mark_last_busy()
internally to update the last access time of the device before queuing
autosuspend.

Remove the pm_runtime_mark_last_busy() call from the probe function.

Tested on StarFive VisionFive 2 v1.2A board.

Fixes: e1f2e776 ("spi: cadence-qspi: Fix runtime PM imbalance in probe")

Signed-off-by: default avatarAkif Ejaz <akifejaz40@gmail.com>
Link: https://patch.msgid.link/20251203181921.97171-1-akifejaz40@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e83ba2e6

drivers/spi/spi-cadence-quadspi.c

+1 −3
Original line number Diff line number Diff line
@@ -2011,10 +2011,8 @@ static int cqspi_probe(struct platform_device *pdev) 
		goto probe_setup_failed;

	}



	if (!(ddata && (ddata->quirks & CQSPI_DISABLE_RUNTIME_PM))) {

		pm_runtime_mark_last_busy(dev);

	if (!(ddata && (ddata->quirks & CQSPI_DISABLE_RUNTIME_PM)))

		pm_runtime_put_autosuspend(dev);

	}



	return 0;

probe_setup_failed: