Commit 2a22bead authored by Rosen Penev's avatar Rosen Penev Committed by Jakub Kicinski
Browse files

net: mtk_eth_soc: use ethtool_puts 



Allows simplifying get_strings and avoids manual pointer manipulation.

Tested on Belkin RT1800.

Signed-off-by: default avatarRosen Penev <rosenp@gmail.com>
Reviewed-by: default avatarGerhard Engleder <gerhard@engleder-embedded.com>
Link: https://patch.msgid.link/20241011200225.7403-1-rosenp@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 9de722c1

drivers/net/ethernet/mediatek/mtk_eth_soc.c

+2 −4
Original line number Diff line number Diff line
@@ -4329,10 +4329,8 @@ static void mtk_get_strings(struct net_device *dev, u32 stringset, u8 *data) 
	case ETH_SS_STATS: {

		struct mtk_mac *mac = netdev_priv(dev);



		for (i = 0; i < ARRAY_SIZE(mtk_ethtool_stats); i++) {

			memcpy(data, mtk_ethtool_stats[i].str, ETH_GSTRING_LEN);

			data += ETH_GSTRING_LEN;

		}

		for (i = 0; i < ARRAY_SIZE(mtk_ethtool_stats); i++)

			ethtool_puts(&data, mtk_ethtool_stats[i].str);

		if (mtk_page_pool_enabled(mac->hw))

			page_pool_ethtool_stats_get_strings(data);

		break;