Commit 2a86eec6 authored by Caleb Sander Mateos's avatar Caleb Sander Mateos Committed by Jens Axboe
Browse files

ublk: take const ubq pointer in ublk_get_iod() 



ublk_get_iod() doesn't modify the struct ublk_queue it is passed.
Clarify that by making the argument a const pointer.

Move the function definition earlier in the file so it doesn't need a
forward declaration.

Signed-off-by: default avatarCaleb Sander Mateos <csander@purestorage.com>
Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20250430225234.2676781-5-csander@purestorage.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 5a43d935

drivers/block/ublk_drv.c

+7 −8
Original line number Diff line number Diff line
@@ -205,8 +205,13 @@ static void ublk_abort_queue(struct ublk_device *ub, struct ublk_queue *ubq); 
static inline struct request *__ublk_check_and_get_req(struct ublk_device *ub,

		struct ublk_queue *ubq, int tag, size_t offset);

static inline unsigned int ublk_req_build_flags(struct request *req);

static inline struct ublksrv_io_desc *ublk_get_iod(struct ublk_queue *ubq,

						   int tag);



static inline struct ublksrv_io_desc *

ublk_get_iod(const struct ublk_queue *ubq, unsigned tag)

{

	return &ubq->io_cmd_buf[tag];

}



static inline bool ublk_dev_is_user_copy(const struct ublk_device *ub)

{

	return ub->dev_info.flags & (UBLK_F_USER_COPY | UBLK_F_SUPPORT_ZERO_COPY);
@@ -694,12 +699,6 @@ static inline bool ublk_rq_has_data(const struct request *rq) 
	return bio_has_data(rq->bio);

}



static inline struct ublksrv_io_desc *ublk_get_iod(struct ublk_queue *ubq,

		int tag)

{

	return &ubq->io_cmd_buf[tag];

}



static inline struct ublksrv_io_desc *

ublk_queue_cmd_buf(struct ublk_device *ub, int q_id)

{