Commit 2d7b422f authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Jakub Kicinski
Browse files

net: phy: ks8995: constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20241216-sysfs-const-bin_attr-net-v1-2-ec460b91f274@weissschuh.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a2558b41

drivers/net/phy/spi_ks8995.c

+4 −4
Original line number Diff line number Diff line
@@ -289,7 +289,7 @@ static int ks8995_reset(struct ks8995_switch *ks) 
}



static ssize_t ks8995_registers_read(struct file *filp, struct kobject *kobj,

	struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)

	const struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)

{

	struct device *dev;

	struct ks8995_switch *ks8995;
@@ -301,7 +301,7 @@ static ssize_t ks8995_registers_read(struct file *filp, struct kobject *kobj, 
}



static ssize_t ks8995_registers_write(struct file *filp, struct kobject *kobj,

	struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)

	const struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)

{

	struct device *dev;

	struct ks8995_switch *ks8995;
@@ -401,8 +401,8 @@ static const struct bin_attribute ks8995_registers_attr = { 
		.mode   = 0600,

	},

	.size   = KS8995_REGS_SIZE,

	.read   = ks8995_registers_read,

	.write  = ks8995_registers_write,

	.read_new   = ks8995_registers_read,

	.write_new  = ks8995_registers_write,

};



/* ------------------------------------------------------------------------ */