Commit 2f2d42a1 authored by Zhengxu Zhang's avatar Zhengxu Zhang Committed by Namjae Jeon
Browse files

exfat: fdatasync flag should be same like generic_write_sync() 



Test: androbench by default setting, use 64GB sdcard.
 the random write speed:
	without this patch 3.5MB/s
	with this patch 7MB/s

After patch "11a347fb", the random write speed decreased significantly.
the .write_iter() interface had been modified, and check the differences
with generic_file_write_iter(), when calling generic_write_sync() and
exfat_file_write_iter() to call vfs_fsync_range(), the fdatasync flag is
wrong, and make not use the fdatasync mode, and make random write speed
decreased. So use generic_write_sync() instead of vfs_fsync_range().

Fixes: 11a347fb ("exfat: change to get file size from DataLength")
Signed-off-by: default avatarZhengxu Zhang <zhengxu.zhang@unisoc.com>
Acked-by: default avatarYuezhang Mo <Yuezhang.Mo@sony.com>
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
parent cbbf0a75

fs/exfat/file.c

+2 −3
Original line number Diff line number Diff line
@@ -622,9 +622,8 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter) 
	if (pos > valid_size)

		pos = valid_size;



	if (iocb_is_dsync(iocb) && iocb->ki_pos > pos) {

		ssize_t err = vfs_fsync_range(file, pos, iocb->ki_pos - 1,

				iocb->ki_flags & IOCB_SYNC);

	if (iocb->ki_pos > pos) {

		ssize_t err = generic_write_sync(iocb, iocb->ki_pos - pos);

		if (err < 0)

			return err;

	}