Commit 31400754 authored by Hariprasad Kelam's avatar Hariprasad Kelam Committed by David S. Miller
Browse files

octeontx2-pf: Fix ethtool support for SDP representors 



The hardware supports multiple MAC types, including RPM, SDP, and LBK.
However, features such as link settings and pause frames are only available
on RPM MAC, and not supported on SDP or LBK.

This patch updates the ethtool operations logic accordingly to reflect
this behavior.

Fixes: 2f7f33a0 ("octeontx2-pf: Add representors for sdp MAC")
Signed-off-by: default avatarHariprasad Kelam <hkelam@marvell.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9d8a99c5

drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c

+5 −5
Original line number Diff line number Diff line
@@ -315,7 +315,7 @@ static void otx2_get_pauseparam(struct net_device *netdev, 
	struct otx2_nic *pfvf = netdev_priv(netdev);

	struct cgx_pause_frm_cfg *req, *rsp;



	if (is_otx2_lbkvf(pfvf->pdev))

	if (is_otx2_lbkvf(pfvf->pdev) || is_otx2_sdp_rep(pfvf->pdev))

		return;



	mutex_lock(&pfvf->mbox.lock);
@@ -347,7 +347,7 @@ static int otx2_set_pauseparam(struct net_device *netdev, 
	if (pause->autoneg)

		return -EOPNOTSUPP;



	if (is_otx2_lbkvf(pfvf->pdev))

	if (is_otx2_lbkvf(pfvf->pdev) || is_otx2_sdp_rep(pfvf->pdev))

		return -EOPNOTSUPP;



	if (pause->rx_pause)
@@ -941,8 +941,8 @@ static u32 otx2_get_link(struct net_device *netdev) 
{

	struct otx2_nic *pfvf = netdev_priv(netdev);



	/* LBK link is internal and always UP */

	if (is_otx2_lbkvf(pfvf->pdev))

	/* LBK and SDP links are internal and always UP */

	if (is_otx2_lbkvf(pfvf->pdev) || is_otx2_sdp_rep(pfvf->pdev))

		return 1;

	return pfvf->linfo.link_up;

}
@@ -1413,7 +1413,7 @@ static int otx2vf_get_link_ksettings(struct net_device *netdev, 
{

	struct otx2_nic *pfvf = netdev_priv(netdev);



	if (is_otx2_lbkvf(pfvf->pdev)) {

	if (is_otx2_lbkvf(pfvf->pdev) || is_otx2_sdp_rep(pfvf->pdev)) {

		cmd->base.duplex = DUPLEX_FULL;

		cmd->base.speed = SPEED_100000;

	} else {