Unverified Commit 33822d79 authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Mark Brown
Browse files

ASoC: cs35l56: Use SND_SOC_BYTES_E_ACC() for CAL_DATA_RB control 



Use the new SND_SOC_BYTES_E_ACC() macro instead of SND_SOC_BYTES_E()
to define the CAL_DATA_RB control, so that it is marked as read-only
and volatile.

This avoids userland code expecting to be able to write to it and
then getting an unexpected EPERM error, or assuming that its value
can never change.

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20251120134437.1179191-5-rf@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4dd7f8ae

sound/soc/codecs/cs35l56.c

+3 −2
Original line number Diff line number Diff line
@@ -1099,8 +1099,9 @@ static int cs35l56_cal_data_ctl_set(struct snd_kcontrol *kcontrol, 
static const struct snd_kcontrol_new cs35l56_cal_data_restore_controls[] = {

	SND_SOC_BYTES_E("CAL_DATA", 0, sizeof(struct cirrus_amp_cal_data) / sizeof(u32),

			cs35l56_cal_data_ctl_get, cs35l56_cal_data_ctl_set),

	SND_SOC_BYTES_E("CAL_DATA_RB", 0, sizeof(struct cirrus_amp_cal_data) / sizeof(u32),

			cs35l56_cal_data_rb_ctl_get, NULL),

	SND_SOC_BYTES_E_ACC("CAL_DATA_RB", 0, sizeof(struct cirrus_amp_cal_data) / sizeof(u32),

			cs35l56_cal_data_rb_ctl_get, NULL,

			SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE),

};



static int cs35l56_set_fw_suffix(struct cs35l56_private *cs35l56)