Commit 3406114a authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Jakub Kicinski
Browse files

sh_eth: Convert to DEFINE_SIMPLE_DEV_PM_OPS() 



Convert the Renesas SuperH Ethernet driver from an open-coded dev_pm_ops
structure to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr().  This lets
us drop the checks for CONFIG_PM and CONFIG_PM_SLEEP without impacting
code size, while increasing build coverage.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Tested-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://patch.msgid.link/ee4def57eb68dd2c32969c678ea916d2233636ed.1756998732.git.geert+renesas@glider.be


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 86e62571

drivers/net/ethernet/renesas/sh_eth.c

+2 −11
Original line number Diff line number Diff line
@@ -3443,8 +3443,6 @@ static void sh_eth_drv_remove(struct platform_device *pdev) 
	free_netdev(ndev);

}



#ifdef CONFIG_PM

#ifdef CONFIG_PM_SLEEP

static int sh_eth_wol_setup(struct net_device *ndev)

{

	struct sh_eth_private *mdp = netdev_priv(ndev);
@@ -3527,15 +3525,8 @@ static int sh_eth_resume(struct device *dev) 


	return ret;

}

#endif



static const struct dev_pm_ops sh_eth_dev_pm_ops = {

	SET_SYSTEM_SLEEP_PM_OPS(sh_eth_suspend, sh_eth_resume)

};

#define SH_ETH_PM_OPS (&sh_eth_dev_pm_ops)

#else

#define SH_ETH_PM_OPS NULL

#endif

static DEFINE_SIMPLE_DEV_PM_OPS(sh_eth_dev_pm_ops, sh_eth_suspend, sh_eth_resume);



static const struct platform_device_id sh_eth_id_table[] = {

	{ "sh7619-ether", (kernel_ulong_t)&sh7619_data },
@@ -3555,7 +3546,7 @@ static struct platform_driver sh_eth_driver = { 
	.id_table = sh_eth_id_table,

	.driver = {

		   .name = CARDNAME,

		   .pm = SH_ETH_PM_OPS,

		   .pm = pm_sleep_ptr(&sh_eth_dev_pm_ops),

		   .of_match_table = of_match_ptr(sh_eth_match_table),

	},

};