Commit 86e62571 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Jakub Kicinski
Browse files

sh_eth: Remove dummy Runtime PM callbacks 



Since commit 63d00be6 ("PM: runtime: Allow unassigned
->runtime_suspend|resume callbacks"), unassigned
.runtime_{suspend,resume}() callbacks are treated the same as dummy
callbacks that just return zero.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Tested-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://patch.msgid.link/ab2a8bb51eb7d02426f4072c27523c8f41ac1ad4.1756998732.git.geert+renesas@glider.be


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8c0b9ed2

drivers/net/ethernet/renesas/sh_eth.c

+0 −13
Original line number Diff line number Diff line
@@ -3529,21 +3529,8 @@ static int sh_eth_resume(struct device *dev) 
}

#endif



static int sh_eth_runtime_nop(struct device *dev)

{

	/* Runtime PM callback shared between ->runtime_suspend()

	 * and ->runtime_resume(). Simply returns success.

	 *

	 * This driver re-initializes all registers after

	 * pm_runtime_get_sync() anyway so there is no need

	 * to save and restore registers here.

	 */

	return 0;

}



static const struct dev_pm_ops sh_eth_dev_pm_ops = {

	SET_SYSTEM_SLEEP_PM_OPS(sh_eth_suspend, sh_eth_resume)

	SET_RUNTIME_PM_OPS(sh_eth_runtime_nop, sh_eth_runtime_nop, NULL)

};

#define SH_ETH_PM_OPS (&sh_eth_dev_pm_ops)

#else