Commit 383a02f6 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: xtensa: use new GPIO line value setter callbacks 

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250709-gpiochip-set-rv-gpio-remaining-v1-15-b8950f69618d@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 735ddc67

drivers/gpio/gpio-xtensa.c

+4 −2
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ static int xtensa_expstate_get_value(struct gpio_chip *gc, unsigned offset) 
	return !!(expstate & BIT(offset));

}



static void xtensa_expstate_set_value(struct gpio_chip *gc, unsigned offset,

static int xtensa_expstate_set_value(struct gpio_chip *gc, unsigned int offset,

				     int value)

{

	unsigned long flags, saved_cpenable;
@@ -114,6 +114,8 @@ static void xtensa_expstate_set_value(struct gpio_chip *gc, unsigned offset, 
	__asm__ __volatile__("wrmsk_expstate %0, %1"

			     :: "a" (val), "a" (mask));

	disable_cp(flags, saved_cpenable);



	return 0;

}



static struct gpio_chip impwire_chip = {
@@ -130,7 +132,7 @@ static struct gpio_chip expstate_chip = { 
	.ngpio		= 32,

	.get_direction	= xtensa_expstate_get_direction,

	.get		= xtensa_expstate_get_value,

	.set		= xtensa_expstate_set_value,

	.set_rv		= xtensa_expstate_set_value,

};



static int xtensa_gpio_probe(struct platform_device *pdev)