Commit 735ddc67 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: xtensa: remove unneeded .set() callback 

GPIO core deals just fine with input-only controllers not implementing
the .set() callback. Remove the unneeded dummy implementation.

Link: https://lore.kernel.org/r/20250709-gpiochip-set-rv-gpio-remaining-v1-14-b8950f69618d@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent ae8bcae8

drivers/gpio/gpio-xtensa.c

+0 −7
Original line number Diff line number Diff line
@@ -86,12 +86,6 @@ static int xtensa_impwire_get_value(struct gpio_chip *gc, unsigned offset) 
	return !!(impwire & BIT(offset));

}



static void xtensa_impwire_set_value(struct gpio_chip *gc, unsigned offset,

				    int value)

{

	BUG(); /* output only; should never be called */

}



static int xtensa_expstate_get_direction(struct gpio_chip *gc, unsigned offset)

{

	return GPIO_LINE_DIRECTION_OUT; /* output only */
@@ -128,7 +122,6 @@ static struct gpio_chip impwire_chip = { 
	.ngpio		= 32,

	.get_direction	= xtensa_impwire_get_direction,

	.get		= xtensa_impwire_get_value,

	.set		= xtensa_impwire_set_value,

};



static struct gpio_chip expstate_chip = {