Commit 38bc4ac4 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'drm-fixes-2022-06-24' of git://anongit.freedesktop.org/drm/drm 

Pull drm fixes from Dave Airlie:
 "Fixes for this week, bit larger than normal, but I think the last
  couple have been quieter, and it's only rc4.

  There are a lot of small msm fixes, and a slightly larger set of vc4
  fixes. The vc4 fixes clean up a lot of crashes around the rPI4
  hardware differences from earlier ones, and problems in the page flip
  and modeset code which assumed earlier hw, so I thought it would be
  okay to keep them in.

  Otherwise, it's a few amdgpu, i915, sun4i and a panel quirk.

  amdgpu:
   - Adjust GTT size logic
   - eDP fix for RMB
   - DCN 3.15 fix
   - DP training fix
   - Color encoding fix for DCN2+

  sun4i:
   - multiple suspend fixes

  vc4:
   - rework driver split for rpi4, fixes mulitple crashers.

  panel:
   - quirk for Aya Neo Next

  i915:
   - Revert low voltage SKU check removal to fix display issues
   - Apply PLL DCO fraction workaround for ADL-S
   - Don't show engine classes not present in client fdinfo

  msm:
   - Workaround for parade DSI bridge power sequencing
   - Fix for multi-planar YUV format offsets
   - Limiting WB modes to max sspp linewidth
   - Fixing the supported rotations to add 180 back for IGT
   - Fix to handle pm_runtime_get_sync() errors to avoid unclocked
     access in the bind() path for dpu driver
   - Fix the irq_free() without request issue which was a being hit
     frequently in CI.
   - Fix to add minimum ICC vote in the msm_mdss pm_resume path to
     address bootup splats
   - Fix to avoid dereferencing without checking in WB encoder
   - Fix to avoid crash during suspend in DP driver by ensuring
     interrupt mask bits are updated
   - Remove unused code from dpu_encoder_virt_atomic_check()
   - Fix to remove redundant init of dsc variable
   - Fix to ensure mmap offset is initialized to avoid memory corruption
     from unpin/evict
   - Fix double runpm disable in probe-defer path
   - VMA fenced-unpin fixes
   - Fix for WB max-width
   - Fix for rare dp resolution change issue"

* tag 'drm-fixes-2022-06-24' of git://anongit.freedesktop.org/drm/drm: (41 commits)
  amd/display/dc: Fix COLOR_ENCODING and COLOR_RANGE doing nothing for DCN20+
  drm/amd/display: Fix typo in override_lane_settings
  drm/amd/display: Fix DC warning at driver load
  drm/amd: Revert "drm/amd/display: keep eDP Vdd on when eDP stream is already enabled"
  drm/amdgpu: Adjust logic around GTT size (v3)
  drm/sun4i: Return if frontend is not present
  drm/vc4: fix error code in vc4_check_tex_size()
  drm/sun4i: Add DMA mask and segment size
  drm/vc4: hdmi: Fixed possible integer overflow
  drm/i915/display: Re-add check for low voltage sku for max dp source rate
  drm/i915/fdinfo: Don't show engine classes not present
  drm/i915: Implement w/a 22010492432 for adl-s
  drm: panel-orientation-quirks: Add quirk for Aya Neo Next
  drm/msm/dp: force link training for display resolution change
  drm/msm/dpu: limit wb modes based on max_mixer_width
  drm/msm/dp: check core_initialized before disable interrupts at dp_display_unbind()
  drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf
  drm/msm: Don't overwrite hw fence in hw_init
  drm/msm: Drop update_fences()
  drm/vc4: Warn if some v3d code is run on BCM2711
  ...
parents cbe232ab 1e9124df

drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

+14 −6
Original line number Diff line number Diff line
@@ -1798,18 +1798,26 @@ int amdgpu_ttm_init(struct amdgpu_device *adev) 
	DRM_INFO("amdgpu: %uM of VRAM memory ready\n",

		 (unsigned) (adev->gmc.real_vram_size / (1024 * 1024)));



	/* Compute GTT size, either bsaed on 3/4th the size of RAM size

	/* Compute GTT size, either based on 1/2 the size of RAM size

	 * or whatever the user passed on module init */

	if (amdgpu_gtt_size == -1) {

		struct sysinfo si;



		si_meminfo(&si);

		gtt_size = min(max((AMDGPU_DEFAULT_GTT_SIZE_MB << 20),

			       adev->gmc.mc_vram_size),

			       ((uint64_t)si.totalram * si.mem_unit * 3/4));

	}

	else

		/* Certain GL unit tests for large textures can cause problems

		 * with the OOM killer since there is no way to link this memory

		 * to a process.  This was originally mitigated (but not necessarily

		 * eliminated) by limiting the GTT size.  The problem is this limit

		 * is often too low for many modern games so just make the limit 1/2

		 * of system memory which aligns with TTM. The OOM accounting needs

		 * to be addressed, but we shouldn't prevent common 3D applications

		 * from being usable just to potentially mitigate that corner case.

		 */

		gtt_size = max((AMDGPU_DEFAULT_GTT_SIZE_MB << 20),

			       (u64)si.totalram * si.mem_unit / 2);

	} else {

		gtt_size = (uint64_t)amdgpu_gtt_size << 20;

	}



	/* Initialize GTT memory pool */

	r = amdgpu_gtt_mgr_init(adev, gtt_size);

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c

+1 −1
Original line number Diff line number Diff line
@@ -550,7 +550,7 @@ static void dcn315_clk_mgr_helper_populate_bw_params( 
		if (!bw_params->clk_table.entries[i].dtbclk_mhz)

			bw_params->clk_table.entries[i].dtbclk_mhz = def_max.dtbclk_mhz;

	}

	ASSERT(bw_params->clk_table.entries[i].dcfclk_mhz);

	ASSERT(bw_params->clk_table.entries[i-1].dcfclk_mhz);

	bw_params->vram_type = bios_info->memory_type;

	bw_params->num_channels = bios_info->ma_channel_number;

	if (!bw_params->num_channels)

drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

+1 −1
Original line number Diff line number Diff line
@@ -944,7 +944,7 @@ static void override_lane_settings(const struct link_training_settings *lt_setti 


		return;



	for (lane = 1; lane < LANE_COUNT_DP_MAX; lane++) {

	for (lane = 0; lane < LANE_COUNT_DP_MAX; lane++) {

		if (lt_settings->voltage_swing)

			lane_settings[lane].VOLTAGE_SWING = *lt_settings->voltage_swing;

		if (lt_settings->pre_emphasis)

drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c

+2 −22
Original line number Diff line number Diff line
@@ -1766,29 +1766,9 @@ void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context) 
				break;

			}

		}



		/*

		 * TO-DO: So far the code logic below only addresses single eDP case.

		 * For dual eDP case, there are a few things that need to be

		 * implemented first:

		 *

		 * 1. Change the fastboot logic above, so eDP link[0 or 1]'s

		 * stream[0 or 1] will all be checked.

		 *

		 * 2. Change keep_edp_vdd_on to an array, and maintain keep_edp_vdd_on

		 * for each eDP.

		 *

		 * Once above 2 things are completed, we can then change the logic below

		 * correspondingly, so dual eDP case will be fully covered.

		 */



		// We are trying to enable eDP, don't power down VDD if eDP stream is existing

		if ((edp_stream_num == 1 && edp_streams[0] != NULL) || can_apply_edp_fast_boot) {

		// We are trying to enable eDP, don't power down VDD

		if (can_apply_edp_fast_boot)

			keep_edp_vdd_on = true;

			DC_LOG_EVENT_LINK_TRAINING("Keep eDP Vdd on\n");

		} else {

			DC_LOG_EVENT_LINK_TRAINING("No eDP stream enabled, turn eDP Vdd off\n");

		}

	}



	// Check seamless boot support

drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp.c

+3 −0
Original line number Diff line number Diff line
@@ -212,6 +212,9 @@ static void dpp2_cnv_setup ( 
		break;

	}



	/* Set default color space based on format if none is given. */

	color_space = input_color_space ? input_color_space : color_space;



	if (is_2bit == 1 && alpha_2bit_lut != NULL) {

		REG_UPDATE(ALPHA_2BIT_LUT, ALPHA_2BIT_LUT0, alpha_2bit_lut->lut0);

		REG_UPDATE(ALPHA_2BIT_LUT, ALPHA_2BIT_LUT1, alpha_2bit_lut->lut1);