Commit 38f3fc2e authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Greg Kroah-Hartman
Browse files

serial: pch: Don't initialize uart_port's spin_lock. 



There is no need to directly initialize the spinlock_t in struct
uart_port. The structure is later passed to uart_add_one_port() which
initialize the complete struct including the lock member.

Remove spin_lock_init() on uart_port's internal lock.

Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20240301215246.891055-17-bigeasy@linutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f8ff23eb

drivers/tty/serial/pch_uart.c

+0 −2
Original line number Diff line number Diff line
@@ -1725,8 +1725,6 @@ static struct eg20t_port *pch_uart_init_port(struct pci_dev *pdev, 
		 KBUILD_MODNAME ":" PCH_UART_DRIVER_DEVICE "%d",

		 priv->port.line);



	spin_lock_init(&priv->port.lock);



	pci_set_drvdata(pdev, priv);

	priv->trigger_level = 1;

	priv->fcr = 0;