Commit 396a788b authored by Jacek Kowalski's avatar Jacek Kowalski Committed by Tony Nguyen
Browse files

ixgbe: drop unnecessary casts to u16 / int 



Remove unnecessary casts of constant values to u16.
C's integer promotion rules make them ints no matter what.

Additionally drop cast from u16 to int in return statements.

Signed-off-by: default avatarJacek Kowalski <jacek@jacekk.info>
Suggested-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent d45dda49

drivers/net/ethernet/intel/ixgbe/ixgbe_common.c

+2 −2
Original line number Diff line number Diff line
@@ -1739,9 +1739,9 @@ int ixgbe_calc_eeprom_checksum_generic(struct ixgbe_hw *hw) 
		}

	}



	checksum = (u16)IXGBE_EEPROM_SUM - checksum;

	checksum = IXGBE_EEPROM_SUM - checksum;



	return (int)checksum;

	return checksum;

}



/**

drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c

+2 −2
Original line number Diff line number Diff line
@@ -373,9 +373,9 @@ static int ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw) 
		}

	}



	checksum = (u16)IXGBE_EEPROM_SUM - checksum;

	checksum = IXGBE_EEPROM_SUM - checksum;



	return (int)checksum;

	return checksum;

}



/**

drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c

+2 −2
Original line number Diff line number Diff line
@@ -1060,9 +1060,9 @@ static int ixgbe_calc_checksum_X550(struct ixgbe_hw *hw, u16 *buffer, 
			return status;

	}



	checksum = (u16)IXGBE_EEPROM_SUM - checksum;

	checksum = IXGBE_EEPROM_SUM - checksum;



	return (int)checksum;

	return checksum;

}



/** ixgbe_calc_eeprom_checksum_X550 - Calculates and returns the checksum