Commit 3978d53d authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: ump: Don't open legacy substream for an inactive group 

When a UMP Group is inactive, we shouldn't allow users to access it
via the legacy MIDI access.  Add the group active flag check and
return -ENODEV if it's inactive.

Link: https://patch.msgid.link/20241129094546.32119-2-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent aaa55faa

sound/core/ump.c

+2 −0
Original line number Diff line number Diff line
@@ -1087,6 +1087,8 @@ static int snd_ump_legacy_open(struct snd_rawmidi_substream *substream) 
	guard(mutex)(&ump->open_mutex);

	if (ump->legacy_substreams[dir][group])

		return -EBUSY;

	if (!ump->groups[group].active)

		return -ENODEV;

	if (dir == SNDRV_RAWMIDI_STREAM_OUTPUT) {

		if (!ump->legacy_out_opens) {

			err = snd_rawmidi_kernel_open(&ump->core, 0,