Commit 3a0c3a40 authored by Timur Kristóf's avatar Timur Kristóf Committed by Alex Deucher
Browse files

drm/amd/pm: Disable ULV even if unsupported (v3) 



Always send PPSMC_MSG_DisableULV to the SMC, even if ULV mode
is unsupported, to make sure it is properly turned off.

v3:
Simplify si_disable_ulv further.
Always check the return value of amdgpu_si_send_msg_to_smc.

Fixes: 841686df ("drm/amdgpu: add SI DPM support (v4)")
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarTimur Kristóf <timur.kristof@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c661219c

drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c

+3 −7
Original line number Diff line number Diff line
@@ -5637,14 +5637,10 @@ static int si_populate_smc_t(struct amdgpu_device *adev, 


static int si_disable_ulv(struct amdgpu_device *adev)

{

	struct si_power_info *si_pi = si_get_pi(adev);

	struct si_ulv_param *ulv = &si_pi->ulv;

	PPSMC_Result r;



	if (ulv->supported)

		return (amdgpu_si_send_msg_to_smc(adev, PPSMC_MSG_DisableULV) == PPSMC_Result_OK) ?

			0 : -EINVAL;



	return 0;

	r = amdgpu_si_send_msg_to_smc(adev, PPSMC_MSG_DisableULV);

	return (r == PPSMC_Result_OK) ? 0 : -EINVAL;

}



static bool si_is_state_ulv_compatible(struct amdgpu_device *adev,