Commit 3a3bc9bb authored by Marc Kleine-Budde's avatar Marc Kleine-Budde
Browse files

can: rockchip-canfd: rkcanfd_start_xmit(): use can_dev_dropped_skb() instead... 


can: rockchip-canfd: rkcanfd_start_xmit(): use can_dev_dropped_skb() instead of can_dropped_invalid_skb()

In addition to can_dropped_invalid_skb(), the helper function
can_dev_dropped_skb() checks whether the device is in listen-only mode and
discards the skb accordingly.

Replace can_dropped_invalid_skb() by can_dev_dropped_skb() to also drop
skbs in for listen-only mode.

Reported-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Closes: https://lore.kernel.org/all/20251017-bizarre-enchanted-quokka-f3c704-mkl@pengutronix.de/
Fixes: ff60bfba ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller")
Link: https://patch.msgid.link/20251017-fix-skb-drop-check-v1-3-556665793fa4@pengutronix.de


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 0bee15a5

drivers/net/can/rockchip/rockchip_canfd-tx.c

+1 −1
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ netdev_tx_t rkcanfd_start_xmit(struct sk_buff *skb, struct net_device *ndev) 
	int err;

	u8 i;



	if (can_dropped_invalid_skb(ndev, skb))

	if (can_dev_dropped_skb(ndev, skb))

		return NETDEV_TX_OK;



	if (!netif_subqueue_maybe_stop(priv->ndev, 0,