Commit 3b430954 authored by Kuan-Wei Chiu's avatar Kuan-Wei Chiu Committed by Takashi Iwai
Browse files

ALSA: hda: Fix headset detection failure due to unstable sort 



The auto_parser assumed sort() was stable, but the kernel's sort() uses
heapsort, which has never been stable. After commit 0e02ca29
("lib/sort: optimize heapsort with double-pop variation"), the order of
equal elements changed, causing the headset to fail to work.

Fix the issue by recording the original order of elements before
sorting and using it as a tiebreaker for equal elements in the
comparison function.

Fixes: b9030a00 ("ALSA: hda - Use standard sort function in hda_auto_parser.c")
Reported-by: default avatarAustrum <austrum.lab@gmail.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219158


Tested-by: default avatarAustrum <austrum.lab@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarKuan-Wei Chiu <visitorckw@gmail.com>
Link: https://patch.msgid.link/20250128165415.643223-1-visitorckw@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 519b2b14

sound/pci/hda/hda_auto_parser.c

+7 −1
Original line number Diff line number Diff line
@@ -80,7 +80,11 @@ static int compare_input_type(const void *ap, const void *bp) 


	/* In case one has boost and the other one has not,

	   pick the one with boost first. */

	if (a->has_boost_on_pin != b->has_boost_on_pin)

		return (int)(b->has_boost_on_pin - a->has_boost_on_pin);



	/* Keep the original order */

	return a->order - b->order;

}



/* Reorder the surround channels
@@ -400,6 +404,8 @@ int snd_hda_parse_pin_defcfg(struct hda_codec *codec, 
	reorder_outputs(cfg->speaker_outs, cfg->speaker_pins);



	/* sort inputs in the order of AUTO_PIN_* type */

	for (i = 0; i < cfg->num_inputs; i++)

		cfg->inputs[i].order = i;

	sort(cfg->inputs, cfg->num_inputs, sizeof(cfg->inputs[0]),

	     compare_input_type, NULL);

sound/pci/hda/hda_auto_parser.h

+1 −0
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ struct auto_pin_cfg_item { 
	unsigned int is_headset_mic:1;

	unsigned int is_headphone_mic:1; /* Mic-only in headphone jack */

	unsigned int has_boost_on_pin:1;

	int order;

};



struct auto_pin_cfg;