Commit 3fccba8f authored by Ley Foon Tan's avatar Ley Foon Tan Committed by Jakub Kicinski
Browse files

net: stmmac: dwmac4: Fix the MTL_OP_MODE_*_MASK operation 



In order to mask off the bits, we need to use the '~' operator to invert
all the bits of _MASK and clear them.

Signed-off-by: default avatarLey Foon Tan <leyfoon.tan@starfivetech.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241107063637.2122726-3-leyfoon.tan@starfivetech.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6d4a34fe

drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c

+2 −2
Original line number Diff line number Diff line
@@ -274,7 +274,7 @@ static void dwmac4_dma_rx_chan_op_mode(struct stmmac_priv *priv, 
	} else {

		pr_debug("GMAC: disable RX SF mode (threshold %d)\n", mode);

		mtl_rx_op &= ~MTL_OP_MODE_RSF;

		mtl_rx_op &= MTL_OP_MODE_RTC_MASK;

		mtl_rx_op &= ~MTL_OP_MODE_RTC_MASK;

		if (mode <= 32)

			mtl_rx_op |= MTL_OP_MODE_RTC_32;

		else if (mode <= 64)
@@ -343,7 +343,7 @@ static void dwmac4_dma_tx_chan_op_mode(struct stmmac_priv *priv, 
	} else {

		pr_debug("GMAC: disabling TX SF (threshold %d)\n", mode);

		mtl_tx_op &= ~MTL_OP_MODE_TSF;

		mtl_tx_op &= MTL_OP_MODE_TTC_MASK;

		mtl_tx_op &= ~MTL_OP_MODE_TTC_MASK;

		/* Set the transmit threshold */

		if (mode <= 32)

			mtl_tx_op |= MTL_OP_MODE_TTC_32;