Commit 415c33d2 authored by Ai Chao's avatar Ai Chao Committed by Hans de Goede
Browse files

platform/x86: huawei-wmi: use sysfs_emit() instead of sprintf() 



Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: default avatarAi Chao <aichao@kylinos.cn>
Link: https://lore.kernel.org/r/20240319064243.297320-1-aichao@kylinos.cn


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 79bd127f

drivers/platform/x86/huawei-wmi.c

+4 −4
Original line number Diff line number Diff line
@@ -379,7 +379,7 @@ static ssize_t charge_control_start_threshold_show(struct device *dev, 
	if (err)

		return err;



	return sprintf(buf, "%d\n", start);

	return sysfs_emit(buf, "%d\n", start);

}



static ssize_t charge_control_end_threshold_show(struct device *dev,
@@ -392,7 +392,7 @@ static ssize_t charge_control_end_threshold_show(struct device *dev, 
	if (err)

		return err;



	return sprintf(buf, "%d\n", end);

	return sysfs_emit(buf, "%d\n", end);

}



static ssize_t charge_control_thresholds_show(struct device *dev,
@@ -405,7 +405,7 @@ static ssize_t charge_control_thresholds_show(struct device *dev, 
	if (err)

		return err;



	return sprintf(buf, "%d %d\n", start, end);

	return sysfs_emit(buf, "%d %d\n", start, end);

}



static ssize_t charge_control_start_threshold_store(struct device *dev,
@@ -562,7 +562,7 @@ static ssize_t fn_lock_state_show(struct device *dev, 
	if (err)

		return err;



	return sprintf(buf, "%d\n", on);

	return sysfs_emit(buf, "%d\n", on);

}



static ssize_t fn_lock_state_store(struct device *dev,