Commit 79bd127f authored by Ai Chao's avatar Ai Chao Committed by Hans de Goede
Browse files

platform/x86: asus-wmi: use sysfs_emit() instead of sprintf() 



This changes all *_show attributes in asus-wmi.c to use sysfs_emit()
instead of the older method of writing to the output buffer manually.

Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: default avatarAi Chao <aichao@kylinos.cn>
Link: https://lore.kernel.org/r/20240319055636.150289-1-aichao@kylinos.cn


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 6d9b262a

drivers/platform/x86/asus-wmi.c

+4 −4
Original line number Diff line number Diff line
@@ -2326,7 +2326,7 @@ static ssize_t pwm1_show(struct device *dev, 


	/* If we already set a value then just return it */

	if (asus->agfn_pwm >= 0)

		return sprintf(buf, "%d\n", asus->agfn_pwm);

		return sysfs_emit(buf, "%d\n", asus->agfn_pwm);



	/*

	 * If we haven't set already set a value through the AGFN interface,
@@ -2512,7 +2512,7 @@ static ssize_t asus_hwmon_temp1(struct device *dev, 
	if (err < 0)

		return err;



	return sprintf(buf, "%ld\n",

	return sysfs_emit(buf, "%ld\n",

			  deci_kelvin_to_millicelsius(value & 0xFFFF));

}
@@ -4061,7 +4061,7 @@ static ssize_t show_sys_wmi(struct asus_wmi *asus, int devid, char *buf) 
	if (value < 0)

		return value;



	return sprintf(buf, "%d\n", value);

	return sysfs_emit(buf, "%d\n", value);

}



#define ASUS_WMI_CREATE_DEVICE_ATTR(_name, _mode, _cm)			\