Commit 455bf7d9 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Vinod Koul
Browse files

phy: rockchip-samsung-dcphy: Discard pm_runtime_put() return value 



Passing pm_runtime_put() return value to the callers is not particularly
useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.  It also happens when the kernel is
configured with CONFIG_PM unset.

Accordingly, update samsung_mipi_dcphy_exit() to simply discard the
return value of pm_runtime_put() and always return success to the
caller.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2281919.Icojqenx9y@rafael.j.wysocki


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 8bb108e4

drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c

+3 −1
Original line number Diff line number Diff line
@@ -1508,7 +1508,9 @@ static int samsung_mipi_dcphy_exit(struct phy *phy) 
{

	struct samsung_mipi_dcphy *samsung = phy_get_drvdata(phy);



	return pm_runtime_put(samsung->dev);

	pm_runtime_put(samsung->dev);



	return 0;

}



static const struct phy_ops samsung_mipi_dcphy_ops = {