Unverified Commit 46378ab9 authored by Emil Svendsen's avatar Emil Svendsen Committed by Mark Brown
Browse files

ASoC: tlv320adcx140: fix word length 



The word length is the physical width of the channel slots. So the
hw_params would misconfigure when format width and physical width
doesn't match. Like S24_LE which has data width of 24 bits but physical
width of 32 bits. So if using asymmetric formats you will get a lot of
noise.

Fixes: 689c7655 ("ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family")
Signed-off-by: default avatarEmil Svendsen <emas@bang-olufsen.dk>
Signed-off-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Link: https://patch.msgid.link/20260113-sound-soc-codecs-tvl320adcx140-v4-4-8f7ecec525c8@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d89aad92

sound/soc/codecs/tlv320adcx140.c

+2 −2
Original line number Diff line number Diff line
@@ -725,7 +725,7 @@ static int adcx140_hw_params(struct snd_pcm_substream *substream, 
	struct adcx140_priv *adcx140 = snd_soc_component_get_drvdata(component);

	u8 data = 0;



	switch (params_width(params)) {

	switch (params_physical_width(params)) {

	case 16:

		data = ADCX140_16_BIT_WORD;

		break;
@@ -740,7 +740,7 @@ static int adcx140_hw_params(struct snd_pcm_substream *substream, 
		break;

	default:

		dev_err(component->dev, "%s: Unsupported width %d\n",

			__func__, params_width(params));

			__func__, params_physical_width(params));

		return -EINVAL;

	}