Commit 4dc8f99d authored Jul 13, 2023 by Waqar Hameed Committed by Jonathan Cameron Jul 20, 2023

iio: Make return value check for set_trigger_state() consistent



In `iio_trigger_detach_poll_func()` the return value from
`trig->ops->set_trigger_state(trig, false)` is checked with `if (ret)`.
However, in `iio_trigger_attach_poll_func()` it is checked with
`if (ret < 0)`. Resolve this mismatch by only checking for `if (ret)` in
both places.

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
Link: https://lore.kernel.org/r/pndv8eojdey.fsf@axis.com


Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent b7297d45

drivers/iio/industrialio-trigger.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -313,7 +313,7 @@ int iio_trigger_attach_poll_func(struct iio_trigger *trig,
		/* Enable trigger in driver */
		if (trig->ops && trig->ops->set_trigger_state && notinuse) {
		ret = trig->ops->set_trigger_state(trig, true);
		if (ret < 0)
		if (ret)
		goto out_free_irq;
		}