Commit 4ebe8d47 authored Sep 12, 2023 by Filipe Manana Committed by David Sterba Oct 12, 2023

btrfs: mark transaction id check as unlikely at btrfs_mark_buffer_dirty()



At btrfs_mark_buffer_dirty(), having a transaction id mismatch is never
expected to happen and it usually means there's a bug or some memory
corruption due to a bitflip for example. So mark the condition as unlikely
to optimize code generation as well as to make it obvious for human
readers that it is a very unexpected condition.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 20cbe460

fs/btrfs/disk-io.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4403,7 +4403,7 @@ void btrfs_mark_buffer_dirty(struct btrfs_trans_handle *trans,
		/* This is an active transaction (its state < TRANS_STATE_UNBLOCKED). */
		ASSERT(trans->transid == fs_info->generation);
		btrfs_assert_tree_write_locked(buf);
		if (transid != fs_info->generation) {
		if (unlikely(transid != fs_info->generation)) {
		btrfs_abort_transaction(trans, -EUCLEAN);
		btrfs_crit(fs_info,
		"dirty buffer transid mismatch, logical %llu found transid %llu running transid %llu",