Commit 52075d2c authored by Diogo Ivo's avatar Diogo Ivo Committed by Tzung-Bi Shih
Browse files

platform/chrome: sensorhub: Support devices without FIFO_INT_ENABLE 



Some devices (such as Smaug) report having MOTION_SENSE_FIFO but do not
support controlling the behaviour of the FIFO interrupt via the
FIFO_INT_ENABLE command and in these cases the interrupt is always
enabled. However, currently the code assumes that if MOTION_SENSE_FIFO
is supported then so is FIFO_INT_ENABLE, and when it tries to enable
the interrupt via this command and an unsupported device reports a
failure it then propagates this into failing the sensors probe.

Interpret the return value -EINVAL as a device where FIFO_INT_ENABLE is
not present and the interrupt is always enabled.

Signed-off-by: default avatarDiogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
Link: https://lore.kernel.org/r/20251112-diogo-smaug_ec_sensorhub-v1-1-f71d4e9eb9d4@tecnico.ulisboa.pt


Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent 944edca8

drivers/platform/chrome/cros_ec_sensorhub_ring.c

+11 −0
Original line number Diff line number Diff line
@@ -129,6 +129,17 @@ int cros_ec_sensorhub_ring_fifo_enable(struct cros_ec_sensorhub *sensorhub, 
	/* We expect to receive a payload of 4 bytes, ignore. */

	if (ret > 0)

		ret = 0;

	/*

	 * Some platforms (such as Smaug) don't support the FIFO_INT_ENABLE

	 * command and the interrupt is always enabled.  In the case, it

	 * returns -EINVAL.

	 *

	 * N.B: there is no danger of -EINVAL meaning any other invalid

	 * parameter since fifo_int_enable.enable is a bool and can never

	 * be in an invalid range.

	 */

	else if (ret == -EINVAL)

		ret = 0;



	return ret;

}